chore: more precommit hooks #1325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some basic hooks to prevent usual whitespace nits (mixed line endings, trailing whitespace and missing EOF) and merge conflicts * Lint YAML (actions) and validate GH Actions (two validators because they are both quite useful for different reasons!) * Also validate shell scripts and Makefiles (NOTE: one of the GH Action validators also shellchecks the scripts in them :) * Finally, skip checks on generated files (diff/patches and testing expected outputs).
Automatic linting of all the files. Also, commit with --no-verify because there's still a bunch of things that require manual fixing.
|
Ah, forgot to double-check tests locally :S The |
There's a lot of stuff reported so excluding it from the time being, will probably create a separate PR just for this.
jjmaestro
force-pushed
the
chore-more-precommit-hooks
branch
from
445ed20
to
7e5e93e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a bit of a winter house cleaning :)
Add a bunch of pre-commit hooks:
Then, run
pre-commit run --all-filesto lint and fix the things that can be automatically fixed.Finally, a few more commits to fix the stuff that can't be fixed manually:
examples/because there's quite a bunch of warnings so it's probably better to leave those for another PR.