Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maybe in bazel_features_repo macro #47

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Use maybe in bazel_features_repo macro #47

merged 1 commit into from
Mar 4, 2024

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Mar 3, 2024 •
edited
Loading

Makes it easier to include bazel_features in WORKSPACE projects.

@meteorcloudy
Copy link
Collaborator

Is this for WORKSPACE's use case?

@fmeum
Copy link
Member Author

fmeum commented Mar 4, 2024

Is this for WORKSPACE's use case?

Yes, I noticed that it's unnecessarily difficult to include it there for this reason.

@meteorcloudy meteorcloudy merged commit 4b4f65e into main Mar 4, 2024
9 checks passed
@meteorcloudy meteorcloudy deleted the fmeum-patch-3 branch March 4, 2024 10:07
@meteorcloudy
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @meteorcloudy