only update ASG once after all detach/delete instance request

bazaarvoice · Mar 6, 2019 · 775eb56 · 775eb56
1 parent 980154a
commit 775eb56
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/cloud-aws/src/main/java/com/sequenceiq/cloudbreak/cloud/aws/AwsResourceConnector.java b/cloud-aws/src/main/java/com/sequenceiq/cloudbreak/cloud/aws/AwsResourceConnector.java
@@ -673,13 +673,14 @@ public List<CloudResourceStatus> downscale(AuthenticatedContext auth, CloudStack
                 detachInstances(instanceIdsBatches, detachInstancesRequest, amazonASClient);
                 terminateInstances(instanceIdsBatches, amazonEC2Client);
                 LOGGER.info("Terminated instances in stack '{}': '{}'", auth.getCloudContext().getId(), instanceIdsBatches);
-                try {
-                    amazonASClient.updateAutoScalingGroup(new UpdateAutoScalingGroupRequest()
-                        .withAutoScalingGroupName(asGroupName)
-                        .withMaxSize(getInstanceCount(stack, vms.get(0).getTemplate().getGroupName())));
-                } catch (AmazonServiceException e) {
-                    LOGGER.warn(e.getErrorMessage());
-                }
+            }
+
+            try {
+                amazonASClient.updateAutoScalingGroup(new UpdateAutoScalingGroupRequest()
+                    .withAutoScalingGroupName(asGroupName)
+                    .withMaxSize(getInstanceCount(stack, vms.get(0).getTemplate().getGroupName())));
+            } catch (AmazonServiceException e) {
+                LOGGER.warn(e.getErrorMessage());
             }
         }
         return check(auth, resources);