-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[보스 몬스터 잡기 미션] 김동우 미션 제출합니다. #23
Open
polarpolar914
wants to merge
23
commits into
baton-mission:polarpolar914
Choose a base branch
from
polarpolar914:main
base: polarpolar914
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement input validation for the boss monster's initial HP to ensure it's within the 100-300 range. If an invalid value is entered, throw IllegalArgumentException and prompt for the input again.
Implement input validation for the player's initial HP and MP(sum is 200), and name. If an invalid value is entered, throw IllegalArgumentException and prompt for correct input.
feat: add hp(Boss)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
보스 몬스터 잡기 미션
코드 설명
게임 로직과 관련된 부분들을 Service로,
그 외 부분을 Domain으로 구분했습니다.
질문사항
Setter사용을 최대한 지앙할려고 매번 객체를 새로 생성하도록 구현하였습니다. 이 게임의 구현과 같이 setter를 사용하지 않을 경우에는 객체 생성이 빈번해 질 경우에는 setter를 빈번히 사용하도록 타협하는 것이 오히려 좋을 지 궁금합니다.