Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert texture renaming #63

Merged
merged 2 commits into from
Apr 26, 2024
Merged

revert texture renaming #63

merged 2 commits into from
Apr 26, 2024

Conversation

z64a
Copy link
Collaborator

@z64a z64a commented Apr 25, 2024

same as PR on pmret, do not modify texture names during dump or build

@bates64
Copy link
Owner

bates64 commented Apr 25, 2024

I'm generally in support of this if it is accepted in upstream: pmret/papermario#1185. However, ideally, #57 gets out of development hell and we sync this change using the standard method, so I'm going to close this if thats OK. (Unless anyone else is so inclined, I intend to get to #57 once my university commitments are over.)

@bates64 bates64 closed this Apr 25, 2024
@z64a z64a reopened this Apr 25, 2024
@z64a
Copy link
Collaborator Author

z64a commented Apr 25, 2024

merging this so star rod can target a standard set of texture names

src/model.c Show resolved Hide resolved
@bates64 bates64 merged commit 46314c0 into main Apr 26, 2024
7 checks passed
@bates64 bates64 deleted the revert-tex-names branch April 26, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants