Fix RenameProject method signature in Project Repository interface #35
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the RenameProject method in the Repository interface to accept two arguments (id and name) instead of one. This change aligns the interface with the actual implementation in GormRepository.
Changed the parameter name 'id' to 'projectID' for clarity and consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an inconsistency between the
Repositoryinterface and theGormRepositoryimplementation.Changes:
idtoprojectIDinGormRepository'sRenameProjectmethod.RenameProjectinRepositoryinterface fromRenameProject(projectID uint) errortoRenameProject(projectID uint, name string) error.The method in the
GormRepositorystruct was designed to take two arguments (idandname), while theRepositoryinterface defined it to take only one (projectID). Although this didn't prevent functionality, it created inconsistency between the interface and implementation. Updating the interface makes them consistent, improving overall code readability and maintainability.