Seperate Phonebook into a standalone node #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
I'm using node-red-contrib-fritz since the first day I'm using Node-RED 👍 Mainly as a callmonitor to notify via slack. Nowadays a lot of spam is incoming, so I wanted to use node-red-contrib-fritz also for this scenario. Unfortunately I didn't read the readme close enough, so I didn't realize, that the generic fritz nodes would fit my needs... So I decided to contribute and implement it into the phonebook node. Finished with my work I realized the readme and so on...
Nevertheless I'm finding it easier to add an entry with an JSON object (pic1) as an input (it has the same structure as the output of a phonebook (pic2)), as using a XML(pic3).
I would be glad, if you review my PR. But I won't be sad, if you decline/reject it 😉 I just don't wanna withheld it.
NExt time I have to read the readme better ;)
Greets,
Benjamin