Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Log Base.org Homepage Events #819

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

brendan-defi
Copy link
Collaborator

What changed? Why?

  • Added event logging to base.org homepage links, leveraging AnalyticsProvider

Notes to reviewers

  • GetConnected section required extracting the social links into a client-side sub-component

How has it been tested?
locally

Copy link

vercel bot commented Aug 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2024 6:23pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2024 6:23pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 11, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@zencephalon zencephalon merged commit 61f4af9 into master Aug 12, 2024
7 checks passed
@zencephalon zencephalon deleted the chore/log-base-homepage-events branch August 12, 2024 04:28
kirkas pushed a commit that referenced this pull request Oct 21, 2024
* created analytics providers for baseweb homepage

* implemented event logging on hero CTAs

* implemented event logging on partnerships links

* event logging on commitment link

* events on GetConnected social links

* removed unused imports / sub-components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants