Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updata openocean #1464

Closed
wants to merge 2 commits into from
Closed

Conversation

openocean-admin
Copy link

What changed? Why?

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 10:06am

Copy link

vercel bot commented Dec 23, 2024

@openocean-admin is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 23, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns
Copy link
Member

wbnns commented Dec 27, 2024

@openocean-admin

Heya! Thanks for building on Base!

We require that defi apps linked to from base.org include a terms of service / terms and conditions page for users. It doesn't appear that this is present on the linked page. In order to continue the review, could you all please update and resubmit?

@wbnns wbnns closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base ecosystem review This is ecosystem related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants