Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return type and ensure proper handling of Wei in formatWei function #1454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viktorking7
Copy link

What changed? Why?

  • Changed: The formatWei function was updated to properly handle bigint values for Wei.
  • Reason: Previously, the function returned a number or a string ('...') when the wei parameter was undefined, but it didn’t properly handle the conversion from Wei to Ether and then back to Wei. The update ensures that the function returns the correct parsed Ether value after formatting Wei.

Notes to reviewers

  • This change modifies the return type of the formatWei function. Please pay special attention to the handling of edge cases, especially when the wei parameter is undefined.
  • Ensure the precision and rounding of the values are handled correctly when converting from Wei to Ether and back to Wei.

How has it been tested?

  • Manually tested with various values for wei, including both defined and undefined cases.
  • The function has been validated to ensure that for defined wei values, the output is a properly formatted number, and for undefined, it returns '...'.

Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 9:08am

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Dec 21, 2024

@viktorking7 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants