fix return type and ensure proper handling of Wei in formatWei function #1454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
formatWei
function was updated to properly handlebigint
values for Wei.wei
parameter wasundefined
, but it didn’t properly handle the conversion from Wei to Ether and then back to Wei. The update ensures that the function returns the correct parsed Ether value after formatting Wei.Notes to reviewers
formatWei
function. Please pay special attention to the handling of edge cases, especially when thewei
parameter is undefined.How has it been tested?
wei
, including both defined and undefined cases.wei
values, the output is a properly formattednumber
, and forundefined
, it returns'...'.