Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecosystem): Add Toucan to ecosystem.json #1311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aspiers
Copy link

@aspiers aspiers commented Nov 28, 2024


What changed? Why?
Adds Toucan to the ecosystem page.

Notes to reviewers
Toucan has been live on Base since April 2024 (e.g. see https://dexscreener.com/watchlist/H4Elw1i20UH11iuKedY6 and https://app.toucan.earth/contracts#base).

How has it been tested?
Ran yarn workspace @app/web dev on localhost.

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 2:30pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 2:30pm

Copy link

vercel bot commented Nov 28, 2024

Someone is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 28, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@wbnns
Copy link
Member

wbnns commented Dec 7, 2024

@aspiers

Hi there! Thanks for building on Base! Please change the tags from other to defi.

@wbnns wbnns self-assigned this Dec 7, 2024
@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related community contribution labels Dec 7, 2024
@aspiers aspiers force-pushed the toucan branch 2 times, most recently from 72a8540 to c240122 Compare December 7, 2024 10:37
@aspiers
Copy link
Author

aspiers commented Dec 7, 2024

@wbnns Done!

@wbnns
Copy link
Member

wbnns commented Dec 19, 2024

@aspiers

Apologies, we recently updated the way we categorize and subcategorize apps; could you please update your PR, conforming to the new format by removing the tag, and defining the category (defi) and subcategory (dex)?

We'll do our best to review as soon as possible once you do! 🙏

@aspiers
Copy link
Author

aspiers commented Dec 22, 2024

@wbnns Updated. We're not a DEX but I couldn't find a way for us to neatly fit into the new taxonomy. The closest I found was consumer / real world since we tokenize carbon credits which are a form of RWA. We also provide on-chain baskets of carbon tokens which I guess could go under defi / portfolio, but it doesn't seem possible to select both.

@wbnns wbnns removed the change(s) requested One or more changes have been requested label Dec 28, 2024
@wbnns
Copy link
Member

wbnns commented Dec 28, 2024

@aspiers Thank you for this information, this is currently being reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base ecosystem review This is ecosystem related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants