Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Layerswap to the Base Ecosystem page #1263

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

annatantushyan19
Copy link

No description provided.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 18, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 -1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Nov 18, 2024

@annatantushyan19 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 9:48am
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 9:48am

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annatantushyan19

Hi there! Thanks for this PR! Could you please update the landing page to point to one that is Base-focused with the network already selected, for folks that would be coming from base.org?

@wbnns wbnns self-assigned this Dec 5, 2024
@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related community contribution labels Dec 5, 2024
Changed the URL as requested
@annatantushyan19
Copy link
Author

@wbnns

Thanks for the feedback! Just updated!

@wbnns
Copy link
Member

wbnns commented Dec 19, 2024

@annatantushyan19

Hi there! Thanks for the update! Apologies, we recently updated the way we categorize and subcategorize apps; could you please rebase + update your PR, conforming to the new format by removing the tag, and defining the category (infra) and subcategory (bridge)?

We'll do our best to review as soon as possible once you do! 🙏

Removed tag, added category and subcategory
@annatantushyan19
Copy link
Author

@wbnns just updated! Let me know if it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base ecosystem review This is ecosystem related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants