Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Variable Name Issues and Grammar Errors #1231

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Anon-im
Copy link

@Anon-im Anon-im commented Nov 8, 2024

What changed? Why?

I corrected several errors and inconsistencies in the documentation that could hinder understanding:
in arrays-exercise.md; imports-sbs.md; deployment-in-remix.md; introduction-to-solidity-overview.md; useAccount.md; simple-storage-sbs.md; learning-objectives.md.

• Fixed an error in a variable name.

• Removed unnecessary quotation marks ("), where they were not needed.

• Removed a backtick () that interfered with properly displaying useAccount` as code.

• Found and corrected typos and mistakes in the text.

• Added missing prepositions and made other minor adjustments to improve the readability of the documentation.

Notes to reviewers

These modifications improve the precision and comprehensibility of the docs.

How has it been tested?

No tests needed

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:26pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:26pm

Copy link

vercel bot commented Nov 8, 2024

@Anon-im is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 8, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@Anon-im Anon-im changed the title Fix variable Name Issues and Grammar Errors Fix Variable Name Issues and Grammar Errors Nov 8, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anon-im

Thanks for contributing to Base! Left one comment in-line but once fixed LGTM 👍

@wbnns wbnns self-assigned this Dec 5, 2024
@wbnns wbnns added change(s) requested One or more changes have been requested community contribution labels Dec 5, 2024
@Anon-im
Copy link
Author

Anon-im commented Dec 9, 2024

@Anon-im

Thanks for contributing to Base! Left one comment in-line but once fixed LGTM 👍
@wbnns done!!!

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anon-im Ty!

@wbnns
Copy link
Member

wbnns commented Dec 19, 2024

@Anon-im Please rebase this PR and we will merge.

@Anon-im
Copy link
Author

Anon-im commented Dec 22, 2024

@Anon-im Please rebase this PR and we will merge.

Resolved all conflict and rebased branch! @wbnns

@Anon-im
Copy link
Author

Anon-im commented Dec 23, 2024

@Anon-im Please rebase this PR and we will merge.

Resolved all conflict and rebased branch! @wbnns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change(s) requested One or more changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants