Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Contract Verification docs #1156

Closed
wants to merge 1 commit into from
Closed

update Contract Verification docs #1156

wants to merge 1 commit into from

Conversation

davidstrouk
Copy link

What changed? Why?

Notes to reviewers

This PR draws inspiration from #345, which was closed due to inactivity.

How has it been tested?

  • Reviewed the revised article for clarity, accuracy, and completeness.
  • Verified all links to ensure they correctly point to relevant pages on sepolia.basescan.org.
  • Followed the updated instructions to verify and interact with a contract on sepolia.basescan.org, confirming that the described process works as intended.

@vercel Vercel
Copy link

vercel bot commented Oct 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 7:42pm

@vercel Vercel
Copy link

vercel bot commented Oct 27, 2024

@davidstrouk is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 27, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@wbnns
Copy link
Member

wbnns commented Nov 2, 2024

@davidstrouk

Thanks for this PR! Confirming this is in our backlog, pending to be reviewed.

ericbrown99
ericbrown99 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ericbrown99 ericbrown99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update looks great, thanks for taking the time to address!

@cb-heimdall
Copy link
Collaborator

Review Error for ericbrown99 @ 2024-11-04 19:01:34 UTC
User failed mfa authentication, see go/mfa-help

@wbnns wbnns added base docs review To be reviewed by the Base docs team and removed state: backlog labels Dec 18, 2024
@wbnns wbnns added the change(s) requested One or more changes have been requested label Jan 6, 2025
@wbnns
Copy link
Member

wbnns commented Jan 6, 2025

@davidstrouk Hi there! Can you please rebase to resolve the merge conflict?

@wbnns
Copy link
Member

wbnns commented Jan 14, 2025

@davidstrouk Closing this PR for now; if you'd like to pursue this change please open a new one and we'll do our best to review ASAP.

@wbnns wbnns closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericbrown99 ericbrown99 ericbrown99 approved these changes

@hughescoin hughescoin Awaiting requested review from hughescoin

Assignees
No one assigned
Labels
base docs review To be reviewed by the Base docs team change(s) requested One or more changes have been requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidstrouk @cb-heimdall @wbnns @ericbrown99 @hughescoin