Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminology mismatch Update send-eth.ts #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

defitricks
Copy link

Problem:

In the provided script, the error message in the else block reads:

console.error("Invalid circuit type");

This is inconsistent with the rest of the script, where the term "signature type" is used. The mismatch can lead to confusion during debugging, as it does not align with the --signature-type argument or its intended meaning in the script.


Solution:

Update the error message to correctly refer to "signature type":

console.error("Invalid signature type");

Importance:

  1. Improves Clarity: Ensures the error message accurately describes the issue and aligns with the rest of the script.
  2. Reduces Debugging Complexity: Avoids potential confusion caused by a mismatch in terminology.
  3. Maintains Consistency: Reinforces the usage of the term "signature type," which is integral to the script's functionality.

Changes Made:

Replaced:

console.error("Invalid circuit type");

With:

console.error("Invalid signature type");

This ensures the error message reflects the correct context and matches the argument used in the script.

Fix terminology mismatch in error message for invalid signature type
Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keyspace-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 6:42pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant