Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo, Add Address Validation, Remove Redundant ERC20 Deposit #106

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

savvar9991
Copy link

@savvar9991 savvar9991 commented Nov 27, 2024

Changes

  1. Fixed typo in bridge variable name
  2. Added zero-address validation
  3. Removed duplicate ERC20 deposit
  4. Added proper ERC721 token approval

Correction of typos
Fixed the name of the variable
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 27, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

type correct
Fixed typos in the comments (for example, Counter Party → Counterparty, Explicity → Explicitly).
Improved comments for greater clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants