Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Vault API for auth providers #71

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

akijakya
Copy link
Member

@akijakya akijakya commented Jun 5, 2023

Resolves #53, resolves #58

Switch from our own auth implementations to the ones provided by the Vault api, which does exactly what we did in most cases.

To-do: test with

  • jwt/kubernetes
  • namespaced
  • azure
  • gpc-iam
  • gcp-gce
  • aws-iam
  • aws-ec2

@akijakya akijakya added the kind/enhancement Categorizes issue or PR as related to an improvement. label Jun 5, 2023
@akijakya akijakya self-assigned this Jun 5, 2023
@akijakya akijakya force-pushed the switch-to-official-auth-providers branch 2 times, most recently from bcdb9ea to 4b8f476 Compare June 5, 2023 09:25
@akijakya akijakya force-pushed the switch-to-official-auth-providers branch from 4b8f476 to 840b83f Compare October 18, 2023 12:56
@akijakya akijakya requested a review from a team as a code owner October 18, 2023 12:56
@akijakya akijakya requested review from sagikazarmark and removed request for a team October 18, 2023 12:56
ramizpolic
ramizpolic previously approved these changes Oct 18, 2023
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Clean and simple 🚀
Did you have a chance to test out other auth methods?

@ramizpolic ramizpolic changed the title Use Vault API for auth providers feat: use Vault API for auth providers Nov 29, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Nov 29, 2023
@ramizpolic ramizpolic self-requested a review December 22, 2023 18:43
Signed-off-by: András Jáky <[email protected]>

Signed-off-by: András Jáky <[email protected]>

Signed-off-by: András Jáky <[email protected]>

Signed-off-by: András Jáky <[email protected]>

Signed-off-by: András Jáky <[email protected]>
by the usage of `fallthrough`

Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>

Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>

Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>

Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>

Signed-off-by: András Jáky <[email protected]>
@akijakya akijakya merged commit 6c5d33b into main Jan 18, 2024
14 checks passed
@akijakya akijakya deleted the switch-to-official-auth-providers branch January 18, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. size/L Denotes a PR that changes 500-999 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Vault-supported official auth libraries Replace Azure MSI library
2 participants