Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Generic Webhook #29

Merged
merged 49 commits into from
Jun 4, 2024
Merged

feat: Generic Webhook #29

merged 49 commits into from
Jun 4, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Mar 26, 2024 •
edited
Loading

Overview

@csatib02 csatib02 self-assigned this Mar 26, 2024
@csatib02 csatib02 marked this pull request as draft March 26, 2024 19:59
@csatib02 csatib02 marked this pull request as ready for review March 28, 2024 11:59
@csatib02 csatib02 requested a review from a team as a code owner April 5, 2024 13:01
@csatib02 csatib02 requested review from sagikazarmark and removed request for a team April 5, 2024 13:01
@github-actions github-actions bot added the size/XL Denotes a PR that changes 1000+ lines label Apr 5, 2024
@csatib02 csatib02 added triage/on-hold Indicates an issue or PR is on hold for some reason. priority/soon Must be worked on either currently, or very soon, ideally for the next release labels Apr 29, 2024
ramizpolic
ramizpolic requested changes May 13, 2024
View reviewed changes
e2e/main_test.go Outdated Show resolved Hide resolved
e2e/test/deployment-init-seccontext-vault.yaml Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
pkg/common/common.go Show resolved Hide resolved
pkg/common/config.go Outdated Show resolved Hide resolved
pkg/common/config.go Outdated Show resolved Hide resolved
pkg/provider/bao/config.go Outdated Show resolved Hide resolved
pkg/provider/vault/config.go Outdated Show resolved Hide resolved
pkg/provider/vault/config.go Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
@csatib02 csatib02 added kind/work-in-progress Categorizes issue or PR as work in progress. kind/feature Categorizes issue or PR as related to a new feature. and removed triage/on-hold Indicates an issue or PR is on hold for some reason. labels May 14, 2024
@csatib02 csatib02 force-pushed the feat/generic-webhook branch 2 times, most recently from d65494a to c9596be Compare May 17, 2024 13:15
csatib02 added 15 commits May 20, 2024 12:22
@csatib02
refactor: wip
8dc1b67 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor
df816da 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: genericize main functionality
a4cb69b 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: all mutate objects, only pod remains
5aa9a9a 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: all mutate objects, only pod remains
3abe477 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor
c184da1 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: last commit before refactoring pod.go
ba0c7b9 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: finished
2ff08d0 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: finished
1978752 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
fix: Minor fixes
af73b9b 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
feat(bao_tests): Add bao unit tests
ef438bf 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: Done
d0467e1 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: Final
94880bd 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: finishing touches
2f19ef2 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: finishing touches
8717ee1 
Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 force-pushed the feat/generic-webhook branch from 3f3b52b to 5f60746 Compare May 20, 2024 10:25
ramizpolic
ramizpolic reviewed May 23, 2024
View reviewed changes
e2e/main_test.go Outdated Show resolved Hide resolved
csatib02 added 3 commits May 23, 2024 20:26
@csatib02
fix: use original Bao image
6a02e3b 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
chore: export default timeout on e2e tests
13930e7 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
refactor: Use obj namespace instead of ar namespace, factor out secre…
dc2dec7 
…t Init config, introduce cleanup annotation

Signed-off-by: Bence Csati <[email protected]>
@ramizpolic
Copy link
Member

ramizpolic commented May 24, 2024 •
edited
Loading

Lets just make sure that old annotations are not deleted to allow users to revert to previous webhook if needed for any reason. Other than that, lgtm, awesome work, what a PR 💯

@csatib02 csatib02 force-pushed the feat/generic-webhook branch from 414fda5 to 0514849 Compare May 25, 2024 14:20
@csatib02 csatib02 mentioned this pull request May 25, 2024
Merged
@csatib02
fix: linters
91f33bf 
Signed-off-by: Bence Csati <[email protected]>
This was referenced May 27, 2024
Closed
Closed
Closed
@csatib02
chore: update dependencies
3cd84ab 
Signed-off-by: Bence Csati <[email protected]>
ramizpolic
ramizpolic requested changes Jun 3, 2024
View reviewed changes
pkg/common/common.go Outdated Show resolved Hide resolved
pkg/common/secret_init_config.go Show resolved Hide resolved
pkg/provider/bao/pod.go Outdated Show resolved Hide resolved
pkg/provider/bao/pod.go Outdated Show resolved Hide resolved
pkg/provider/bao/provider.go Show resolved Hide resolved
pkg/provider/common/pod.go Show resolved Hide resolved
pkg/provider/types.go Outdated Show resolved Hide resolved
@csatib02 csatib02 mentioned this pull request Jun 3, 2024
Open
csatib02 added 2 commits June 3, 2024 19:31
@csatib02
fix
f2dcf0a 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
fix: introduced error
a4cf882 
Signed-off-by: Bence Csati <[email protected]>
ramizpolic
ramizpolic approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀

@csatib02 csatib02 merged commit a431943 into main Jun 4, 2024
22 checks passed
@csatib02 csatib02 deleted the feat/generic-webhook branch June 4, 2024 10:25
@csatib02 csatib02 mentioned this pull request Jun 4, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark sagikazarmark is a code owner automatically assigned from bank-vaults/maintainers

Assignees

@csatib02 csatib02

Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/work-in-progress Categorizes issue or PR as work in progress. priority/soon Must be worked on either currently, or very soon, ideally for the next release size/XL Denotes a PR that changes 1000+ lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csatib02 @ramizpolic