Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ldflags for version #211

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

csatib02
Copy link
Member

Overview

  • Adds ldflags to explicitly track version.

@csatib02 csatib02 requested a review from ramizpolic June 25, 2024 07:05
@csatib02 csatib02 self-assigned this Jun 25, 2024
@csatib02 csatib02 requested a review from a team as a code owner June 25, 2024 07:05
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines label Jun 25, 2024
@ramizpolic
Copy link
Member

We should have vars defined in main package to inject the version data into and be able to print them, check this post for details

@csatib02 csatib02 removed the request for review from a team June 25, 2024 07:54
@github-actions github-actions bot added size/M Denotes a PR that changes 100-499 lines and removed size/XS Denotes a PR that changes 0-9 lines labels Jun 25, 2024
@csatib02 csatib02 force-pushed the chore/add-ldflags-to-goreleaser branch from 857ded3 to 6abcde2 Compare June 25, 2024 09:42
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines and removed size/M Denotes a PR that changes 100-499 lines labels Jun 25, 2024
.goreleaser.yaml Outdated Show resolved Hide resolved
Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 force-pushed the chore/add-ldflags-to-goreleaser branch from 14a5f17 to 7d6bf3b Compare July 2, 2024 07:19
@csatib02 csatib02 merged commit 3d4bed4 into main Jul 2, 2024
15 checks passed
@csatib02 csatib02 deleted the chore/add-ldflags-to-goreleaser branch July 2, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants