Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add governance docs #16

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat: add governance docs #16

merged 2 commits into from
Jul 29, 2024

Conversation

csatib02
Copy link
Member

@csatib02
feat: add governance docs
f254ff8 
Signed-off-by: Bence Csati <[email protected]>
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines label Jul 22, 2024
akijakya
akijakya reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks! 🔥

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
sagikazarmark
sagikazarmark approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Generally, it's better to adopt a simple governance process that accurately depicts the status quo (with the potential to iterate) than introducing complicated new processes and this one does just that, so 👍 .

@csatib02
docs: review round No. 1
79814a5 
Signed-off-by: Bence Csati <[email protected]>
akijakya
akijakya approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ramizpolic ramizpolic merged commit 5ce99fb into bank-vaults:main Jul 29, 2024
4 checks passed
@csatib02 csatib02 deleted the cncf/add-governance-docs branch July 29, 2024 12:10
@csatib02 csatib02 self-assigned this Jul 29, 2024
@csatib02 csatib02 mentioned this pull request Oct 29, 2024
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgecse lgecse lgecse approved these changes

@akijakya akijakya akijakya approved these changes

@ramizpolic ramizpolic ramizpolic approved these changes

@sagikazarmark sagikazarmark sagikazarmark approved these changes

Assignees

@csatib02 csatib02

Labels
size/S Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csatib02 @sagikazarmark @ramizpolic @akijakya @lgecse