Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(SSR): add for next projects #1478

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

glennverschooren
Copy link

@glennverschooren glennverschooren commented Oct 7, 2024

Add SSR Support for Next.js - Hydration Issues

Description:

This PR introduces a draft version of server-side rendering (SSR) support for Next.js in the Baloise design system. While I've made progress in implementing SSR, there are still a few issues I couldn't resolve myself.

Current Issues:

Next.js is throwing warnings and errors during the hydration process.
The primary issue is that the HTML generated on the server does not match the HTML on the client, leading to hydration failures.
As a result, the client-side app is not able to hydrate the server-rendered content correctly, causing the mismatch.
Since I’ve been unable to fully fix these issues, I'm opening this PR so you can review the implementation and provide guidance on resolving these problems.

Steps Taken So Far:

Integrated SSR within the Next.js framework.
Attempted to address hydration discrepancies but ran into persistent errors.
I would appreciate any insights or suggestions to help resolve these issues and improve SSR support for the design system.

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: fc24a24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system-core ❌ Failed (Inspect) Oct 7, 2024 1:27pm

Copy link

vercel bot commented Oct 7, 2024

Someone is attempting to deploy a commit to the baloise Team on Vercel.

A member of the Team first needs to authorize it.

@incubator-tekton
Copy link

🚀 Welcome to Baloise ChatOps based GitOps Bot 🎉

- If you want to enable preview environments for this PullRequest, comment with `/preview`. 
- If you want to disable the preview environment for this PR, comment with `/undeploy`. 
- If you need help or want to see the docs, comment with `/help`. 
                            
Make sure to refresh this page after submitting a command.
Preview environments can be redeployed automatically if you enable the webhook for updates to the source branch. :new:

Have fun building awesome apps! :hammer:  :whale2:  :truck:  :ship:

@hirsch88 hirsch88 changed the title Feature/add ssr for next projects ✨ feat(SSR): add for next projects Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants