Skip to content

Commit

Permalink
♿ a11y(bal-nav): button overlays not reachable via keyboard (#1438)
Browse files Browse the repository at this point in the history
* Create PR for #1415

* fix(close): make close button focusable by changing tabindex from -1 to 0

* fix(close): make close button focusable by changing tabindex from -1 to 0

* chore: add changeset

* chore: add changeset

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marinkov, Magdalena <[email protected]>
Co-authored-by: Gery Hirschfeld <[email protected]>
  • Loading branch information
3 people authored Sep 6, 2024
1 parent d8c2bc4 commit 9570144
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/wet-cycles-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': patch
---

**close**: is accessible by the keyboard
2 changes: 1 addition & 1 deletion packages/core/src/components/bal-close/bal-close.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class Close implements ComponentInterface, BalConfigObserver {
type="button"
aria-label={label}
title={label}
tabindex={-1}
tabindex="0"
class={{
...buttonEl.class(),
...buttonEl.modifier('inverted').class(this.inverted),
Expand Down

0 comments on commit 9570144

Please sign in to comment.