Enable esModuleInterop to ease the transition to ES modules

[Page-]

Change-type: patch

If this is a regression, consider adding it to #1898!

Description

Please include a summary of the change and which issue was fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Include at least one commit in your PR that marks the change-type. This can be either specified through a Change-type footer, or by adding the change-type as a prefix to the commit, i.e. minor: Add some new feature. This is so the PR can be automatically versioned and a changelog generated for it by using versionist. Check out semver for a detailed explanation of the different possible change-type values.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

[pipex]

No idea why the tests are failing here, I could not reproduce the following locally

 balena-supervisor-sut-1  |   1) lib/firewall
balena-supervisor-sut-1  |        Basic On/Off operation
balena-supervisor-sut-1  |          should confirm the `changed` event is handled:
balena-supervisor-sut-1  |      TypeError: Descriptor for property spawn is non-configurable and non-writable
balena-supervisor-sut-1  |       at assertValidPropertyDescriptor (node_modules/sinon/lib/sinon/stub.js:158:15)
balena-supervisor-sut-1  |       at Function.stub (node_modules/sinon/lib/sinon/stub.js:85:5)
balena-supervisor-sut-1  |       at stub (node_modules/sinon/lib/sinon/sandbox.js:388:37)

[Page-]

@pipex the issue is that esModuleInterop enforces that a module's exports cannot be modified (since in real ESM they cannot be) and stub(childProcess, 'spawn').callsFake(...) is attempting to modify the child_process exports

[cywang117]

Does that explain why the test error can't be produced locally though @Page- ?

Looking online, there doesn't seem to be any clear solution other than wrapping the thing that calls spawn in a function, and stubbing that wrapper function.