Make rotation delay configurable #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point we hardcode a 3 seconds delay before applying display rotation, which on some systems is not enough, while on other systems it is too much. This patch exposes a `ROTATE_DELAY` variable that makes the delay configurable. Resolves: #171 Change-type: patch Signed-off-by: Michal Toman <[email protected]>
mtoman
force-pushed
the
mtoman/rotate-delay
branch
from
fb7f73b
to
2648f76
Compare
|
@mtoman I ran this quickly on a pi3 I had connected to my display and it all seems to work correctly |
|
I've also tested this on a Pi5 and it seems to work fine. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point we hardcode a 3 seconds delay before applying display rotation, which on some systems is not enough, while on other systems it is too much.
This patch exposes a
ROTATE_DELAYvariable that makes the delay configurable.