Add EXTRA_FLAGS for extended flag support #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new environment variable EXTRA_FLAGS so we can extend the existing flags passed to Chromium instead of clobbering them all with FLAGS and trying to reproduce the whole list ourselves.
For example, for our IoT project we need
--audio-buffer-size=2048
and--audio-output-channels=8
, so we can do this:instead of having this monstrosity (which requires us to keep track of window sizes):