Balancer pause helper #1211
Open
Balancer pause helper #1211
+349
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lozanopo
approved these changes
Jan 8, 2025
EndymionJkb
reviewed
Jan 10, 2025
EndymionJkb
reviewed
Jan 11, 2025
EndymionJkb
reviewed
Jan 11, 2025
EndymionJkb
reviewed
Jan 11, 2025
EndymionJkb
reviewed
Jan 11, 2025
EndymionJkb
reviewed
Jan 11, 2025
EndymionJkb
reviewed
Jan 11, 2025
EndymionJkb
reviewed
Jan 11, 2025
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
…alancer-v3-monorepo into balancer-pause-helper
EndymionJkb
reviewed
Jan 16, 2025
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
…alancer-v3-monorepo into balancer-pause-helper
joaobrunoah
approved these changes
Jan 20, 2025
| import { IVaultAdmin } from "@balancer-labs/v3-interfaces/contracts/vault/IVaultAdmin.sol"; | ||
| import { SingletonAuthentication } from "@balancer-labs/v3-vault/contracts/SingletonAuthentication.sol"; | ||
|
|
||
| contract PauseHelper is SingletonAuthentication { |
There was a problem hiding this comment.
Should we have an IPauseHelper, that defines all errors, events, and document all functions? Just to make this file cleaner.
There was a problem hiding this comment.
In the same vein, is this confusable with Vault pausing? (i.e., will people think you can also pause the Vault with this?) Maybe it should be called PausePoolHelper.
EndymionJkb
reviewed
Jan 21, 2025
| } | ||
|
|
||
| /*************************************************************************** | ||
| Manage Pools |
There was a problem hiding this comment.
Suggested change
| Manage Pools | |
| Manage Pools |
ASCII art :)
| } | ||
|
|
||
| /** | ||
| * @notice Get a range of pools. |
There was a problem hiding this comment.
Suggested change
| * @notice Get a range of pools. | |
| * @notice Get a range of pools. | |
| * @dev Indexes are 0-based and [start, end) (i.e., inclusive of `start`; exclusive of `end`). |
Still think we should clarify this.
| * @param to End index | ||
| * @return pools List of pools | ||
| */ | ||
| function getPools(uint256 from, uint256 to) public view returns (address[] memory pools) { |
There was a problem hiding this comment.
Do we also want a getPoolAt(uint256 index)?
Could also have a getPools() returns (address[] memory pools) that just returns them all.
That way it supports 3 ways of using it:
- simple
getPools()if you know there isn't a pagination issue; - generic iteration: for(i = 0; i < getPoolsCount(); ++i) { address pool = getPoolAt(i); }
- pagination if needed, using getPools(from, to);
| import { IVaultAdmin } from "@balancer-labs/v3-interfaces/contracts/vault/IVaultAdmin.sol"; | ||
| import { SingletonAuthentication } from "@balancer-labs/v3-vault/contracts/SingletonAuthentication.sol"; | ||
|
|
||
| contract PauseHelper is SingletonAuthentication { |
There was a problem hiding this comment.
In the same vein, is this confusable with Vault pausing? (i.e., will people think you can also pause the Vault with this?) Maybe it should be called PausePoolHelper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A helper to stop pools. Only pools that are added to the list can be stopped. The Hypernative keeper must be added to Authentication to access the PauseHelper. The PauseHelper must be added to Authentication to access the Vault pausePool.
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution
Closes #1209