use json5 config #287
Merged
use json5 config #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deirn
added a commit
that referenced
this pull request
Aug 11, 2024
* add streaming json5 api to mcless * work * annotation based comments * gracefully convert json config to json5 * convert array comments to json5 comments * read with regular gson reader * refactor annotation commenter * use list instead of jsonpath * comment plugin config file * fix json -> json5 migration * comment waila config * only show test plugin toggle if it is enabled in the config * don't escape backslashes on comments * gracefully migrate plugin config json * separate debug config * import (cherry picked from commit d4290ce)
deirn
added a commit
that referenced
this pull request
Aug 11, 2024
* add streaming json5 api to mcless * work * annotation based comments * gracefully convert json config to json5 * convert array comments to json5 comments * read with regular gson reader * refactor annotation commenter * use list instead of jsonpath * comment plugin config file * fix json -> json5 migration * comment waila config * only show test plugin toggle if it is enabled in the config * don't escape backslashes on comments * gracefully migrate plugin config json * separate debug config * import (cherry picked from commit d4290ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.