Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Go lint issues #4647

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Fix Go lint issues #4647

merged 7 commits into from
Oct 24, 2024

Commits on Oct 22, 2024

  1. Fix Go lint issues 

    Linear Issue: https://linear.app/expanso/issue/ENG-267/lint-is-failing-but-build-is-still-passing
Github Issue: #4605
    @jamlo
    jamlo committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    19d34ac View commit details
    Browse the repository at this point in the history

  2. Fix Errors unit test 

    Linear Issue: https://linear.app/expanso/issue/ENG-267/lint-is-failing-but-build-is-still-passing
Github Issue: #4605
    @jamlo
    jamlo committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    17fb044 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Use more idiomatic Go to print error messages 

    Linear Issue: https://linear.app/expanso/issue/ENG-267/lint-is-failing-but-build-is-still-passing
Github Issue: #4605
    @jamlo
    jamlo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d42d027 View commit details
    Browse the repository at this point in the history

  2. Revert the changes for explicit embedded struct calling 

    Linear Issue: https://linear.app/expanso/issue/ENG-267/lint-is-failing-but-build-is-still-passing
Github Issue: #4605
    @jamlo
    jamlo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    624dff4 View commit details
    Browse the repository at this point in the history

  3. Linting: Replace gomnd by mnd 

    Linear Issue: https://linear.app/expanso/issue/ENG-267/lint-is-failing-but-build-is-still-passing
Github Issue: #4605
    @jamlo
    jamlo committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    678e1f9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into jamlo/fix-lint-tests

    @jamlo
    jamlo authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7d9467a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge remote-tracking branch 'origin/main' into jamlo/fix-lint-tests

    @jamlo
    jamlo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    415829f View commit details
    Browse the repository at this point in the history