Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New timer implementation #66

Merged
merged 62 commits into from
Sep 2, 2024
Merged

New timer implementation #66

merged 62 commits into from
Sep 2, 2024

Conversation

MrApplejuice
Copy link
Collaborator

@MrApplejuice MrApplejuice commented Mar 10, 2024

This is becoming a rather huge PR... but for a good reason. After this is done, all event types that are available in the babybuddy webapp will be also available in the app itself. This is what it looks like right now:

image

Open issues are:

  • New button placement(s) is not very optimal. Lots of lost space. Thinking about a layout that can fit "to the side" instead.
    • After testing the layout and improving it a bit, I conclude that it is "good enough" for now
  • Bug: When logging in for the first time to some website, no time entries or similar are loaded at all...
  • Bug: After logging out and in again, old timer-texts persist and are not cleared.
  • Bug: Cancel warning should be shown if one attempts to cancel a timer that is running for some time already.
  • Bug: Homeassistant integration not working. Presumable the headers for ingress service are not added with the new interface implementation.
  • Bug: Home assistant support really really buggy
    • Actually, this was wrong. My buggy dev-server for testing home assistant was really really buggy!
  • Bug: When saving fails, and timer is disabled, the buttons for the timer are correctly disabled but the timer controls remain visible
  • Ordering of timeline items incorrect in cases where starttime == endtime and another entry uses starttime < endtime
    • Can easily be achieved by using the "adjust stored" feature of baby buddy
  • Adjust stored resets start and end point ... meh

Update 2024-08-28

  • New bug found that allows duplicate controls to be inserted
    • Only seems to happen for event logging, not for timer logging
bug.mp4
  • Move the save-button to the right in the interface. The left-sided save button is really inefficient.
  • Add update notice!
  • Update app-store images.

Fixes #74, #22
Addresses #73

@MrApplejuice MrApplejuice added this to the Next release milestone Apr 14, 2024
@MrApplejuice
Copy link
Collaborator Author

Bug:

image

Notes editor shown thrice when restoring from saved state.

@MrApplejuice MrApplejuice marked this pull request as ready for review September 2, 2024 18:03
@MrApplejuice MrApplejuice merged commit 918a611 into master Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App is unable to read past entries since latest server software update
1 participant