Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout value on reader thread wait in SMS send example #77

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

devegied
Copy link

timeout value of 2**31 in join was returning immediately on Raspberry Pi

khssnv and others added 2 commits April 14, 2019 18:25
timeout value of 2**31 in join was returning immediately on Raspberry Pi
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.804% when pulling c7a476b on devegied:master into 5c816ba on babca:master.

@coveralls
Copy link

coveralls commented Apr 14, 2019

Coverage Status

Coverage increased (+0.01%) to 89.814% when pulling fe890ca on devegied:master into 5c816ba on babca:master.

@mmmcorpsvit
Copy link

in MS windows too return on default value
where depend from OS this value ? this constant?

Allow user to set (RTS/CTS) and (DSR/DTR) flows control
Copy link
Collaborator

@lcnittl lcnittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR

If you can get rid of the 2 commits that duplicate #76 this can be merged

@lcnittl
Copy link
Collaborator

lcnittl commented Nov 2, 2021

I believe that a newer release of threading treats numbers bigger than 2**29 (have not tested everything between, but 2**30 does this already) like a 0 timeout. Maybe some number conversion somewhere deeper that results in a negative number?
In any case this should be safe to be removed, as the deafult timeout=None waits indefinitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants