Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade node from 16 to 20 #858

Merged
merged 2 commits into from
Mar 22, 2024
Merged

feat: upgrade node from 16 to 20 #858

merged 2 commits into from
Mar 22, 2024

Conversation

vitorsgomes
Copy link
Contributor

@vitorsgomes vitorsgomes commented Mar 22, 2024 •
edited
Loading

Upgrades action to run using node 20, as node 16 is no longer maintained and github actions is removing its support. (https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/)

Testing

The changes were tested using the commit fb8b73c to run a workflow on the repository organizations.spa. The result of the job can be seen here: https://github.com/lessonnine/organizations.spa/actions/runs/8391900002/job/22983507323?pr=2053

image

@vitorsgomes vitorsgomes marked this pull request as ready for review March 22, 2024 14:42
@vitorsgomes vitorsgomes requested a review from a team March 22, 2024 14:43
@amrrbakry
Copy link
Member

I think we also need to upgrade the dependencies in the package.json file since we are now using a different node version. What do you think?

@vitorsgomes
Copy link
Contributor Author

I think we also need to upgrade the dependencies in the package.json file since we are now using a different node version. What do you think?

I just checked here and the dependencies seem to be up to date, probably thanks to Dependabot

amrrbakry
amrrbakry approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@amrrbakry amrrbakry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you so much! If you could also add an entry to the CHANGELOG, that would be great 🏅

@vitorsgomes
Copy link
Contributor Author

LGTM 👍 Thank you so much! If you could also add an entry to the CHANGELOG, that would be great 🏅

Done here, thanks for reviewing it fb8b73c

@amrrbakry amrrbakry merged commit ca7e707 into main Mar 22, 2024
3 checks passed
@amrrbakry amrrbakry deleted the feat/upgrades-node branch March 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrrbakry amrrbakry amrrbakry approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitorsgomes @amrrbakry