Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new generic concept search endpoints #1172

Draft
wants to merge 1 commit into
base: 8.x
Choose a base branch
from

Conversation

cmark
Copy link
Member

@cmark cmark commented Jun 16, 2023

This PR introduces two new endpoints:

  • GET /concepts
  • POST /concepts/search

These endpoints allow generic concept search across all registered CodeSystems (similar to FHIR $lookup, but has many more options, like sorting, paging, term filtering, etc.).

`GET /concepts` and `POST /concepts/search` can be used to easily search
across all available terminologies.
@cmark cmark requested review from apeteri and nagyo June 16, 2023 07:40
@cmark cmark self-assigned this Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (dc3211d) 64.08% compared to head (12c5e0c) 64.03%.
Report is 221 commits behind head on 8.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1172      +/-   ##
============================================
- Coverage     64.08%   64.03%   -0.06%     
- Complexity    12775    12787      +12     
============================================
  Files          1763     1765       +2     
  Lines         59585    59668      +83     
  Branches       5497     5512      +15     
============================================
+ Hits          38184    38206      +22     
- Misses        19032    19086      +54     
- Partials       2369     2376       +7     
Files Coverage Δ
...nal/snowowl/core/request/ConceptSearchRequest.java 78.72% <40.00%> (-5.00%) ⬇️
.../snowowl/core/rest/concepts/ConceptRestSearch.java 0.00% <0.00%> (ø)
...l/core/rest/concepts/ConceptSearchRestService.java 13.33% <13.33%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍏

@cmark cmark added the on hold label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants