feat: ope poc for store #204
Conversation
generic interface generic btree generic cachekv generic transient store support ObjStore changelog Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> object store key Apply review suggestions fix merge conflict fix snapshot revert dependers
Solution: - remove the api changelog
* Problem: MultiStore interface is bloated Solution: - Split out specialied methods from it, keeping the MultiStore generic * Update store/CHANGELOG.md Signed-off-by: yihuang <[email protected]> --------- Signed-off-by: yihuang <[email protected]>
* Problem: nested cache store not efficient Solution: - introduce copy-on-write btree based cache store temp * changelog * rename * Update store/cachekv/store.go Signed-off-by: yihuang <[email protected]> --------- Signed-off-by: yihuang <[email protected]>
Solution: - init cachestore on cachestore lazily. - cleanup some unused stuff. Update store/CHANGELOG.md Signed-off-by: yihuang <[email protected]>
* Support RunAtomic API * add unit test
fix and add test
Solution: - fix and add test to support the usage pattern in ethermint add Discard method to CacheWrap better testing
…258) Solution: - add API NewFromParent to cache multistore. Update store/CHANGELOG.md Signed-off-by: yihuang <[email protected]> fix test fix lint
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for _, store := range cms.stores { | ||
| store.Discard() | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| store = cms.initStore(key, cms.parentStore(key)) | ||
| } | ||
| if key == nil || store == nil { | ||
| panic(fmt.Sprintf("kv store with key %v has not been registered in stores", key)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| panic(fmt.Sprintf("kv store with key %v has not been registered in stores", key)) | ||
| store, ok := cms.getCacheWrapper(key).(types.KVStore) | ||
| if !ok { | ||
| panic(fmt.Sprintf("store with key %v is not KVStore", key)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| for k, v := range cms.stores { | ||
| stores[k] = v.(types.BranchStore).Clone().(types.CacheWrap) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for k, v := range other.stores { | ||
| store, ok := cms.stores[k] | ||
| if !ok { | ||
| store = cms.initStore(k, cms.parentStore(k)) | ||
| } | ||
|
|
||
| store.(types.BranchStore).Restore(v.(types.BranchStore)) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| func (ts *BTreeStore[V]) Iterator(start, end []byte) types.GIterator[V] { | ||
| it, err := ts.BTree.Iterator(start, end) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| func (ts *BTreeStore[V]) ReverseIterator(start, end []byte) types.GIterator[V] { | ||
| it, err := ts.BTree.ReverseIterator(start, end) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| store := types.KVStore(s) | ||
| store, ok := s.(types.KVStore) | ||
| if !ok { | ||
| panic(fmt.Sprintf("store with key %v is not KVStore", key)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| // AssertValidValueLength checks if the value length is within length limit | ||
| func AssertValidValueLength(l int) { | ||
| if l > MaxValueLength { | ||
| panic(errors.New("value is too large")) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| for k, v := range cms.stores { | ||
| if _, ok := other.stores[k]; !ok { | ||
| // clear the cache store if it's not in the other | ||
| v.Discard() | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
* feat: save some memory allocations on un-used cache store * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * Update store/internal/btree/btree.go Signed-off-by: yihuang <[email protected]> --------- Signed-off-by: yihuang <[email protected]>
…#588) * Problem: versiondb/memiavl don't compatible with upstream sdk Solution: - avoid api breaking change * fix build Co-Authored-By: yihuang <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change