Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove wrappedFilePV and delegator, fix create-bls cmd and etc #8

Draft
wants to merge 6 commits into
base: b-harvest/bls-key-separation
Choose a base branch
from

Conversation

wnjoon
Copy link
Collaborator

@wnjoon wnjoon commented Jan 16, 2025

Description

This PR changes the logic including the delegator address while removing the WrappedFilePV structure.

  • Cleaned up the unused field LastSignState in the WrappedFilePV structure and reduced the hierarchy by one level.
  • In babylond create-bls-key, only the bls key is generated based on the password entered as a prompt, and the delegator address is passed as an argument at the time of babylond gen-helper create-bls.
  • Changed to generate priv_validator_key.json and bls key files simultaneously during babylond init.
  • Removed DelegatorAddress from BlsPV struct and removed unnecessary logic to validate DelegatorAddress at ExtendVote().
  • Added an error message to suggest running the init or create-bls-key commands if the key file does not exist at babylond start time. This prevents the node from starting if the key file does not exist, and restricts key files to only be created via specific cli.

@wnjoon
Copy link
Collaborator Author

wnjoon commented Jan 17, 2025

Commit Summary

fd5e873

  • Recreate the WrappedFilePV structure with unnecessary fields removed.
  • Change BlsSigner interface implementation back to WrappedFilePV.

946eab5

  • Add and test InitCmd function that wraps cosmos' InitCmd.
  • Use the function used in create-bls-key to generate a bls key.

57ddd51

  • Remove DelegatorAddress validation when calling ExtendVote function

280de7e

  • Check if key file exists in InitPrivSigner when starting node and output action message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant