Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 8.4 #498

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Allow PHP 8.4 #498

merged 1 commit into from
Nov 21, 2024

Conversation

veewee
Copy link
Collaborator

@veewee veewee commented Oct 25, 2024 •
edited
Loading

Introduces PHP 8.4 support

@veewee veewee marked this pull request as draft October 25, 2024 11:02
@veewee veewee force-pushed the php84 branch 3 times, most recently from a146177 to 1b58a34 Compare October 25, 2024 11:19
@coveralls
Copy link

coveralls commented Oct 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11947663186

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 98.655%
Files with Coverage Reduction New Missed Lines %
src/Psl/DateTime/Internal/high_resolution_time.php 2 80.95%
Totals Coverage Status
Change from base Build 11369981368: -0.04%
Covered Lines: 5353
Relevant Lines: 5426
💛 - Coveralls

@veewee veewee force-pushed the php84 branch 4 times, most recently from 94c99cd to 56a4b36 Compare October 25, 2024 11:53
@veewee veewee requested a review from azjezz November 21, 2024 06:17
@veewee veewee marked this pull request as ready for review November 21, 2024 06:17
@veewee veewee added Priority: Medium This issue may be useful, and needs some attention. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity labels Nov 21, 2024
@azjezz azjezz merged commit 4a9a669 into azjezz:next Nov 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees
No one assigned
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veewee @coveralls @azjezz