Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix psalm 5.20 issues #439

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix psalm 5.20 issues #439

merged 1 commit into from
Jan 19, 2024

Conversation

veewee
Copy link
Collaborator

@veewee veewee commented Jan 18, 2024

Fixes psalm 5.20 issues:
https://github.com/vimeo/psalm/releases/tag/5.20.0

More info about RiskyTruthyFalsyComparison: vimeo/psalm#10502

(Added a comment to that PR, because it causes some code verbosity)

@coveralls
Copy link

coveralls commented Jan 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7580353024

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.014%
Totals Coverage Status
Change from base Build 7570813555: 0.001%
Covered Lines: 4216
Relevant Lines: 4258
💛 - Coveralls

@veewee veewee force-pushed the fix-new-psalm-issues branch from 2b800d8 to dafe99b Compare January 19, 2024 06:33
@veewee veewee added this to the 2.10.0 milestone Jan 19, 2024
@veewee veewee added Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity labels Jan 19, 2024
@veewee veewee force-pushed the fix-new-psalm-issues branch from dafe99b to 4a4ba13 Compare January 19, 2024 06:35
@veewee veewee merged commit 881b821 into azjezz:next Jan 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@veewee @coveralls