Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Str] add after and before helpers #102

Merged
merged 1 commit into from
Jan 17, 2021
Merged

[Str] add after and before helpers #102

merged 1 commit into from
Jan 17, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Nov 8, 2020 •
edited
Loading

closes #75

TODO:

  • implement before{_ci|_last{_ci}} functions Str\
  • implement after{before{_ci|_last{_ci}} functions for Str\
  • implement search_last_ci function for Str\Byte\
  • implement before{_ci|_last{_ci}} functions Str\Byte\
  • implement after{before{_ci|_last{_ci}} functions for Str\Byte\
  • implement before{_ci|_last{_ci}} functions Str\Grapheme\
  • implement after{before{_ci|_last{_ci}} functions for Str\Grapheme\
  • write tests ( keep coverage at 100% )
  • write documentation

@azjezz azjezz added Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably ask for additions or changes. labels Nov 8, 2020
@azjezz azjezz added this to the 0.1.0 milestone Nov 8, 2020
@azjezz azjezz self-assigned this Nov 8, 2020
@coveralls
Copy link

coveralls commented Nov 8, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 780

  • 115 of 115 (100.0%) changed or added relevant lines in 26 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 767: 0.0%
Covered Lines: 2063
Relevant Lines: 2063
💛 - Coveralls

veewee
veewee reviewed Nov 9, 2020
View reviewed changes
src/Psl/Str/Byte/after.php Outdated Show resolved Hide resolved
@azjezz azjezz force-pushed the feature/before-after-helpers branch from e4148a2 to 7ca187e Compare November 9, 2020 17:18
@azjezz azjezz force-pushed the feature/before-after-helpers branch 3 times, most recently from f2b0fba to ae3e898 Compare January 17, 2021 15:24
@azjezz azjezz force-pushed the feature/before-after-helpers branch from ae3e898 to 2451d50 Compare January 17, 2021 15:31
@azjezz azjezz merged commit 8ba16a6 into 0.1.x Jan 17, 2021
@azjezz azjezz added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Jan 17, 2021
@azjezz azjezz deleted the feature/before-after-helpers branch January 17, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee left review comments

Assignees

@azjezz azjezz

Labels
Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

[Str] add after and before helpers
3 participants
@azjezz @coveralls @veewee