Skip to content

Commit

Permalink
Merge branch 'origin/1.1dev'
Browse files Browse the repository at this point in the history
Conflicts:
	dist/webvs.full.min.js
	dist/webvs.min.js
  • Loading branch information
azeem committed Nov 10, 2013
2 parents 90c887f + b047448 commit b57ce5b
Show file tree
Hide file tree
Showing 26 changed files with 1,238 additions and 510 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Webvs uses grunt for build and bower for dependencies. Run the following command

To build the code run `grunt` or `grunt dist`. This generates `webvs.js` and `libs.js` in the `build` directory or the minified files in the `dist` directory respectively.

To run the tests, use `grunt test` command. To debug the code/examples, run `grunt debug`. This runs a webserver at 8080 and a live re-build of the source files.
To run the tests, use `grunt test` command. To debug the code/examples, run `grunt debug`. This runs a webserver at 8000 and a live re-build of the source files.
To debug tests, run `grunt debug_test`. This is same as `grunt debug` but also runs karma test server and opens up the test page where you can do debugging with
the browser code inspector.

Expand Down
1 change: 0 additions & 1 deletion dist/libs.min.js

This file was deleted.

1 change: 1 addition & 0 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ module.exports = function(config) {
files: [
"build/libs.js",
"build/webvs.js",
"test/webgl-debug.js",
"test/base.js",
"test/*.test.js"
],
Expand Down
12 changes: 10 additions & 2 deletions src/Base.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Webvs.checkRequiredOptions = function(options, requiredOptions) {
for(var i in requiredOptions) {
var key = requiredOptions[i];
if(!(key in options)) {
throw new Error("Required option " + key + "not found");
throw new Error("Required option " + key + " not found");
}
}
};
Expand Down Expand Up @@ -183,7 +183,7 @@ Webvs.Promise = Webvs.defineClass(Promise, Object, {
*/
Webvs.joinPromises = function(promises) {
var joinedPromise = new Promise();

promises = _.filter(promises, function(p) {return !_.isUndefined(p);});
if(promises.length === 0) {
joinedPromise.resolve();
} else {
Expand Down Expand Up @@ -262,4 +262,12 @@ Webvs.clamp = function(num, min, max) {
return Math.min(Math.max(num, min), max);
};

Webvs.getComponentClass = function(name) {
var componentClass = Webvs[name];
if(!componentClass) {
throw new Error("Unknown Component class " + name);
}
return componentClass;
};

})(window);
Loading

0 comments on commit b57ce5b

Please sign in to comment.