Move diagnostic handler to a separate struct #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't being used anywhere (aside from `push` and immediate `pop`) and has no impact on the visitor algorithm.
Instead of keeping raw pointer fields (of types like `LLVMValueRef`, `LLVMMetadataRef`) public and defining constructors with different names, provide the `LLVMTypeWrapper` trait with `from_ptr()` `as_ptr()` method for all of them. This will allow to convert all safe wrappers from and to raw pointers with one method, which is going to be helpful for building macros for them.
Add the `DiagnosticHandler` struct which implements `LLVMDiagnosticHandler`, so only that struct and not the whole `Linker` is passed to `LLVMContextSetDiagnosticHandler`. This is going to make writing a safe wrapper for `Context` easier.
tamird
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Last commit LGTM.
Reviewed 1 of 1 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @vadorovsky)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
DiagnosticHandlerstruct which implementsLLVMDiagnosticHandler, so only that struct and not the wholeLinkeris passed toLLVMContextSetDiagnosticHandler.This is going to make writing a safe wrapper for
Contexteasier.Depends on #223
This change is