Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[External] Replace embedded tablesaw.plotly by Maven dependencies (#265) #379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HannesWell
Copy link
Collaborator

Description

This PR (part of #265) replaces the source code of source code of the tablesaw-jsplot sub-project embedded in matheclipse-external with a corresponding Maven dependency.

The Maven coordinates used are:

	<dependency>
		<groupId>tech.tablesaw</groupId>
		<artifactId>tablesaw-jsplot</artifactId>
		<version>0.42.0</version>
	</dependency>

The tablesaw sources embedded in matheclipse-io are not affected.

@axkr is there a reason to not use a Maven dependency?
In contrast to the sources of tablesaw in matheclipse-io those embedded in matheclipse-external seem not to have matheclipse references?

…kr#265)

Replace the embedded source code of the tablesaw-jsplot sub-project with
a corresponding Maven dependency.
The Maven coordinates are (version may of course change):

	<dependency>
		<groupId>tech.tablesaw</groupId>
		<artifactId>tablesaw-jsplot</artifactId>
		<version>0.42.0</version>
	</dependency>
@gitpod-io
Copy link

gitpod-io bot commented Jan 9, 2022

@HannesWell HannesWell requested a review from axkr January 9, 2022 21:57
@HannesWell
Copy link
Collaborator Author

I just noticed that tablesaw-jsplot has a transitive dependency to tablesaw-core which is partially embedded into matheclipse-io. I assume only the part not depending on tablesaw-core was embedded into matheclipse-core.
So I suggest to request changes to the tablesaw project so tablesaw can be made a complete Maven-dependency for core and io and issue #265 can be resolved entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant