feat: middleware #228
Open
feat: middleware #228
+1,286
−473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
random request: could the |
dasfmi
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Overall looks good, but I have couple of points.
- Its missing documentation on how to use it.
- Perhaps now we can get deprecated usage of
NEXT_PUBLIC_AXIOM_TOKENand update the docs to mentionAXIOM_TOKENinstead. - There is now a custom endpoint added by @c-ehrlich, not sure if we need to handle anything related to that or the config takes care of it.
| const webVitalsEndpoint = axiomConfig.getIngestURL(EndpointType.webVitals); | ||
| const logsEndpoint = axiomConfig.getIngestURL(EndpointType.logs); | ||
|
|
||
| const headers = { |
There was a problem hiding this comment.
Our fetch sends a special UserAgent header to identify which SKS is sending the request. Its missing in here. Perhaps you can just proxy the request headers and adds the token on top of?
| ); | ||
|
|
||
| // Return a 204 to the client | ||
| return new NextResponse(null, { status: 204 }); |
There was a problem hiding this comment.
Shouldn't status be returned as error if the request fails? Users might not notice if it always returns 204 even if it fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds middleware that will allow users to proxy their logs and webvital reports to their backend avoiding the need to provide their Axiom token and dataset to the frontend.