Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Sveltekit package and example issues #207

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

jerriclynsjohn
Copy link

As discussed in #198 I'm adding the suggested changes.

@dasfmi
Copy link
Collaborator

dasfmi commented Jun 25, 2024

hey @jerriclynsjohn, great work! I see you are very excited for this, I will take a look in the next couple of days and help get this released 👍

Copy link
Collaborator

@dasfmi dasfmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, there is one thing I am concerned about. The source field, I wanted to make that as simple and limited as possible so that we can build dashboards easily using it. I imagine hooks-server and hooks-client + others, will make it more complex, we need to think how to simplify this. maybe ['source'] + ['browser'] would indicate if its a client or server. or maybe we can introduce a filename field or something? wdyt?

@jerriclynsjohn
Copy link
Author

The PR looks good, there is one thing I am concerned about. The source field, I wanted to make that as simple and limited as possible so that we can build dashboards easily using it. I imagine hooks-server and hooks-client + others, will make it more complex, we need to think how to simplify this. maybe ['source'] + ['browser'] would indicate if its a client or server. or maybe we can introduce a filename field or something? wdyt?

['source'] + ['browser'] sounds like a good strategy. So in this setup source can be just hooks.

@jerriclynsjohn
Copy link
Author

It would actually help to custom name it in handleError in hooks. To enable us to filter errors that happened from hooks.

@dasfmi
Copy link
Collaborator

dasfmi commented Jul 4, 2024

It would actually help to custom name it in handleError in hooks. To enable us to filter errors that happened from hooks.

Lets start with just hooks in first version, then lets think how can we improve it. But, if the name is always hooks for example, then at Axiom we can build a dynamic dashboard that works for everyone

@jerriclynsjohn
Copy link
Author

@schehata Renamed it all to just hooks

@dasfmi dasfmi merged commit 5af4479 into axiomhq:axiom-svelte Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants