Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of changes from the big PR:
TypedIdentifier
, following the grammar spec, that must have a type. Function definitions and variable declarations now useVec<TypedIdentifier>
instead ofVec<Identifier>
.From
impls to easily create instances ofIdentifier
from string literals ("foo".into()
orIdentifier::from("foo")
).Validator
impl forIdentifier
checks that the identifier is in accordance with the grammar.String
to&'static
str in the validator, although customenum
or using theerror_chain
crate would be better here I reckon.