chore: fix wrong denom when adding gas for cosmos source chain #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npty
force-pushed
the
chore/fix-wrong-denom-in-add-cosmos-gas
branch
from
55cf6b0
to
a77b0b7
Compare
nrsirapop
approved these changes
Oct 16, 2024
canhtrinh
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://axelarnetwork.atlassian.net/browse/AXE-6051
Fixed the error when trying to add gas for cosmos source chain from the axelarscan ui.
Issue
The sdk expects the
denom(usomm) from thesearchGMPapi in thegas_paid.returnValues.denomproperty, but the api returns ibc asset format instead (ibc/12A9901F2B585B3563C2AD4919D20ED478CCAB3D7F9ACBB76E829583B99B1DAA).Solution
@nrsirapop helps adding a new property called
assetin the api response, so this pr points to that field instead.