Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure 2 decimal places #298

Merged
merged 3 commits into from
Feb 16, 2024
Merged

chore: ensure 2 decimal places #298

merged 3 commits into from
Feb 16, 2024

Conversation

npty
Copy link
Member

@npty npty commented Feb 16, 2024

Description

AXE-3183

This PR ensures that the gas_execute_multiplier which returns from the getFees API has 2 decimal places at maximum before put into the calculation.

Example

Try calling estimateGasFee function given axelar and optimism are source chain and destination chain respectively.

Before

Execute Gas Multiplier 1.1550000000000002
Execute Gas Multiplier 1.32
axelarnet to optimism fee: 0.00000000000412665 ETH
optimism to axelarnet fee: 0.01002625182289159 ETH

After

Execute Gas Multiplier 1.16
Execute Gas Multiplier 1.32
axelarnet to optimism fee: 0.000000000004133053 ETH
optimism to axelarnet fee: 0.010016512870193104 ETH

@npty npty requested a review from canhtrinh February 16, 2024 12:51
@npty npty self-assigned this Feb 16, 2024
@canhtrinh
Copy link
Collaborator

looks good, let's add a changelog item and then release

@npty npty merged commit c7d6407 into main Feb 16, 2024
4 checks passed
@npty npty deleted the chore/fix-gas-multiplier branch February 16, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants