Skip to content

Commit

Permalink
Add comments for UD Array and LinkedList loaders.
Browse files Browse the repository at this point in the history
  • Loading branch information
awulkiew committed Feb 23, 2020
1 parent bebde89 commit a15736e
Showing 1 changed file with 16 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,14 @@ namespace GraphicalDebugging
{
partial class ExpressionLoader
{
// TODO: Use in UserArrayEntry
// TODO: Storing elemType is not correct because the same loader
// can potentially be used for two different container types storing
// different elements.
// This is not a problem now because before that happens Initialize()
// is called each time the loader is retrieved from the list of loaders.
// This however should probably be changed because it's not efficient to
// initialize loaders and call the debugger multiple times for the same type.

// TODO: The code is similar to std::vector loader, unify if possible
class UserArray : ContiguousContainer
{
Expand Down Expand Up @@ -69,6 +76,14 @@ public override int LoadSize(Debugger debugger, string name)
string elemType;
}

// TODO: Storing elemType is not correct because the same loader
// can potentially be used for two different container types storing
// different elements.
// This is not a problem now because before that happens Initialize()
// is called each time the loader is retrieved from the list of loaders.
// This however should probably be changed because it's not efficient to
// initialize loaders and call the debugger multiple times for the same type.

// TODO: The code is similar to std::list loader, unify if possible
class UserLinkedList : ContainerLoader
{
Expand Down

0 comments on commit a15736e

Please sign in to comment.