Skip to content

Commit

Permalink
Add known issue and change description in readme
Browse files Browse the repository at this point in the history
  • Loading branch information
awulkiew committed Jan 31, 2022
1 parent 1f2c15b commit b9423b5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [Unreleased]
### Known issues
- The visualization is not shown after hiding the webview with another window and showing it again

## [0.3.0]
### Added
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ This extension allows to display graphical representation of variables during de
#### Known issues

* The extension doesn't work for C++ variables defined with `typedef` with GDB, including classes defining member types, e.g. Boost.Geometry `polygon`. This issue [is known](https://github.com/microsoft/vscode-cpptools/issues/3038) and also affects the use of natvis files. If [this proposal](https://github.com/microsoft/MIEngine/issues/1236) was implemented it could potentially allow to work around this issue.
* Geographic polygons with holes are visualized incorrectly if an interior ring is in the viewport and the whole exterior ring is outside. This is a side effect of a workaround for an [issue in Plotly](https://github.com/plotly/plotly.js/issues/6044) which doesn't support geographic polygons with holes.
* Holes of geographic polygons may be visualized incorrectly. This is a side effect of a workaround for an [issue in Plotly](https://github.com/plotly/plotly.js/issues/6044) which doesn't support geographic polygons with holes.
6 changes: 6 additions & 0 deletions src/webview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ export class Webview {
enableScripts: true,
localResourceRoots: [vscode.Uri.file(path.join(this._context.extensionPath, 'resources'))]
});
// this._panel.onDidChangeViewState(
// (e) => {
// // TODO: handle hiding and showing again here?
// },
// null,
// this._context.subscriptions);
this._panel.onDidDispose(
() => {
this._panel = undefined;
Expand Down

0 comments on commit b9423b5

Please sign in to comment.