Fix tortoise orm implementation so it supports related fields #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/5warCPq1EXRFepwYq1g2sT5yDuas |
|
@xouillet thanks for this, would it be possible to add a tests where the current implementation is failing? |
|
After further research, my PR is fixing the same thing as #68 which has a far better implementation. I will look into improving this PR instead of mine. Closing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Current tortoise implementation didn't use tortoise method to correctly fetch related fields, as shown in their documentation https://tortoise-orm.readthedocs.io/en/latest/examples/fastapi.html.
This PR add those methods