Merge pull request #281 from alex-chew/fix-asset-uploader-error-logging

Fix some asset uploader error cases
awslabs · Jun 28, 2019 · b3a9f66 · b3a9f66
2 parents 9a4a214 + 0c0e317
commit b3a9f66
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/lambdas/static-asset-uploader/index.js b/lambdas/static-asset-uploader/index.js
@@ -185,6 +185,9 @@ function cleanS3Bucket(bucketName) {
 function createCatalogDirectory(staticBucketName) {
     let params = { Bucket: staticBucketName, Key: 'catalog/', Body: '' }
     return exports.s3.upload(params).promise()
+        .catch(err => {
+          console.log('Error creating "catalog" directory', err)
+        })
 }
 
 /**
@@ -195,11 +198,11 @@ function createCatalogDirectory(staticBucketName) {
  */
 async function createSdkGenerationFile(staticBucketName) {
     return await exports.s3.headObject({ Bucket: staticBucketName, Key: 'sdkGeneration.json' }).promise()
-        .catch((error) => {
-            console.error(error)
+        .catch(async _error => {
             // assume it's a NotFound error, and upload a new version
+            console.log('Uploading sdkGeneration.json since it seems to not exist')
             let params = { Bucket: staticBucketName, Key: 'sdkGeneration.json', Body: '{}' }
-            return exports.s3.upload(params).promise()
+            return await exports.s3.upload(params).promise()
         })
 
 }
@@ -255,7 +258,8 @@ function processFile(fileStat, readPromises, uploadPromises, bucketName, event,
                 params.ACL = "public-read"
             }
 
-            uploadPromises.push(exports.s3.upload(params, options).promise())
+          uploadPromises.push(exports.s3.upload(params, options).promise()
+              .catch(err => { throw err }))
         })
         .catch(error => {
             console.log(`Failed to upload:`, error)