Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sample KCL app #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve sample KCL app #60

wants to merge 1 commit into from

Conversation

charleswhchan
Copy link

  • change self._SLEEP_SECONDS to self._CHECKPOINT_SLEEP_SECONDS to avoid naming conflict with user code that also implements sleep/delay
  • move process_record(), should_update_sequence(), and checkpoint() after process_records() so the code is more fluent when read and makes the context clearer
  • also added '_' prefix to the aforementioned functions to indicate internal functions

@charleswhchan
Improve sample KCL app
74ff35f 
- change self._SLEEP_SECONDS to self._CHECKPOINT_SLEEP_SECONDS to avoid naming conflict with user code that also implements sleep/delay
- move process_record(), should_update_sequence(), and checkpoint() after process_records() so the code is more fluent when read and makes the context clearer
- also added '_' prefix to the aforementioned functions to indicate internal functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleswhchan